[okl4-developer] Magpie & attribute ((pure))

[Geoffrey Lee]

On Tue, Aug 19, 2008 at 01:57:31PM +1000, Jamie Lennox wrote:
> It appears that magpie doesn't understand __attribute__ ((pure)) as used  
> in <l4/arch/vregs.h>. It comes up when magpie runs over a header with  
> <mutex/mutex.h> included.
>
> It can be easily avoided by shuffling a few headers around such as the  
> patch (only tested on ia32_pc99), but i thought i would let you know as  
> i would have thought this had come up before.
>


Hi Jamie  - thanks for the report, I have tagged your issue
into the issue tracking system.

> Jamie


	-gl

> --- libs/mutex/src/util.h	2008-08-19 13:39:54.000000000 +1000
> +++ libs/mutex/src/util-new.h	2008-08-19 13:39:44.000000000 +1000
> @@ -57,8 +57,10 @@
>   */
>  
>  #include <l4/types.h>
> +#include <l4/thread.h> 
>  #include <mutex/mutex.h>
>  
> +
>  /** @todo FIXME: Add prototypes with doxygen comments - awiggins. */
>  
>  #if defined(CONFIG_HYBRID_MUTEXES)
> 
> --- libs/mutex/include/mutex.h	2008-08-19 13:44:29.000000000 +1000
> +++ libs/mutex/include/mutex-new.h	2008-08-19 13:44:53.000000000 +1000
> @@ -59,8 +59,6 @@
>  #ifndef __LIBMUTEX__MUTEX_H__
>  #define __LIBMUTEX__MUTEX_H__
>  
> -#include <l4/thread.h>
> -
>  #if !defined(CONFIG_USER_MUTEXES)
>  #include <l4/mutex.h>
>  #endif
> 
>  --- libs/c/src/sys-iguana/sys_threadstate.c	2008-08-19 13:43:08.000000000 +1000
> +++ libs/c/src/sys-iguana/sys_threadstate-new.c	2008-08-19 13:42:01.000000000 +1000
> @@ -60,6 +60,7 @@
>  #include <stdio.h>
>  #include <unistd.h>
>  #include <string.h>
> +#include <l4/thread.h> 
>  #include <threadstate.h>
>  
>  void __thread_state_init(void *thread_state_p);
> 

> _______________________________________________
> Developer mailing list
> Developer at okl4.org
> https://lists.okl4.org/mailman/listinfo/developer


--